IB/mlx5: Fix RoCE Address Path fields
authorMajd Dibbiny <majd@mellanox.com>
Mon, 30 Oct 2017 12:23:14 +0000 (14:23 +0200)
committerDoug Ledford <dledford@redhat.com>
Mon, 13 Nov 2017 18:53:22 +0000 (13:53 -0500)
When working over a RoCE network, the UDP source port should be set only
for statically connected QPs (RC, UC and XRC).

Fixes: 2811ba51b049 ("IB/mlx5: Add RoCE fields to Address Vector")
Signed-off-by: Majd Dibbiny <majd@mellanox.com>
Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/mlx5/qp.c

index 74799c7..31ad288 100644 (file)
@@ -2339,8 +2339,12 @@ static int mlx5_set_path(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
                if (err)
                        return err;
                memcpy(path->rmac, ah->roce.dmac, sizeof(ah->roce.dmac));
-               path->udp_sport = mlx5_get_roce_udp_sport(dev, port,
-                                                         grh->sgid_index);
+               if (qp->ibqp.qp_type == IB_QPT_RC ||
+                   qp->ibqp.qp_type == IB_QPT_UC ||
+                   qp->ibqp.qp_type == IB_QPT_XRC_INI ||
+                   qp->ibqp.qp_type == IB_QPT_XRC_TGT)
+                       path->udp_sport = mlx5_get_roce_udp_sport(dev, port,
+                                                                 grh->sgid_index);
                path->dci_cfi_prio_sl = (sl & 0x7) << 4;
                if (gid_type == IB_GID_TYPE_ROCE_UDP_ENCAP)
                        path->ecn_dscp = (grh->traffic_class >> 2) & 0x3f;