[lldb] Make TestModuleLoadedNotifys work with dyld from the shared cache
authorJonas Devlieghere <jonas@devlieghere.com>
Wed, 3 Aug 2022 20:41:33 +0000 (13:41 -0700)
committerJonas Devlieghere <jonas@devlieghere.com>
Wed, 3 Aug 2022 21:24:42 +0000 (14:24 -0700)
Make TestModuleLoadedNotifys work with a dyld from the expanded shared
cache in the DeviceSupport directory. In that case the module path is:

  ~/Library/Developer/Xcode/iOS DeviceSupport/<...>/Symbols/usr/lib/dyld

instead of just:

  /usr/lib/dyld

This makes the test pass when running against an embedded Darwin device.

lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py

index 06169b0..7f26e5e 100644 (file)
@@ -82,8 +82,10 @@ class ModuleLoadedNotifysTestCase(TestBase):
                         module = lldb.SBTarget.GetModuleAtIndexFromEvent(i, event)
                         # On macOS Ventura and later, dyld and the main binary
                         # will be loaded again when dyld moves itself into the
-                        # shared cache.
-                        if module.file.fullpath not in ['/usr/lib/dyld', exe]:
+                        # shared cache. Use the basename so this also works
+                        # when reading dyld from the expanded shared cache.
+                        exe_basename = lldb.SBFileSpec(exe).basename
+                        if module.file.basename not in ['dyld', exe_basename]:
                             self.assertTrue(module not in already_loaded_modules, '{} is already loaded'.format(module))
                         already_loaded_modules.append(module)
                         if self.TraceOn():