nvme-apple: don't unquiesce the I/O queues in apple_nvme_reset_work
authorChristoph Hellwig <hch@lst.de>
Tue, 1 Nov 2022 15:00:45 +0000 (16:00 +0100)
committerJens Axboe <axboe@kernel.dk>
Wed, 2 Nov 2022 14:35:34 +0000 (08:35 -0600)
apple_nvme_reset_work schedules apple_nvme_remove, to be called, which
will call apple_nvme_disable and unquiesce the I/O queues.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20221101150050.3510-10-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/apple.c

index 6c09703..24e224c 100644 (file)
@@ -1154,7 +1154,6 @@ out:
        nvme_get_ctrl(&anv->ctrl);
        apple_nvme_disable(anv, false);
        nvme_mark_namespaces_dead(&anv->ctrl);
-       nvme_start_queues(&anv->ctrl);
        if (!queue_work(nvme_wq, &anv->remove_work))
                nvme_put_ctrl(&anv->ctrl);
 }