fbdev/broadsheetfb: Call device_remove_file() with hardware device
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 13 Jun 2023 11:06:46 +0000 (13:06 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 27 Jun 2023 07:58:48 +0000 (09:58 +0200)
Call device_remove_file() with the same device that has been used
for device_create_file(), which is the hardware device stored in
struct fb_info.device. Prepares fbdev for making struct fb_info.dev
optional.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230613110953.24176-12-tzimmermann@suse.de
drivers/video/fbdev/broadsheetfb.c

index 5f18af8..5a5fe4b 100644 (file)
@@ -1200,7 +1200,7 @@ static void broadsheetfb_remove(struct platform_device *dev)
        if (info) {
                struct broadsheetfb_par *par = info->par;
 
-               device_remove_file(info->dev, &dev_attr_loadstore_waveform);
+               device_remove_file(info->device, &dev_attr_loadstore_waveform);
                unregister_framebuffer(info);
                fb_deferred_io_cleanup(info);
                par->board->cleanup(par);