spi: Replace if-else-if by bitops and multiplications
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 10 Jul 2023 15:49:20 +0000 (18:49 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 10 Jul 2023 17:27:44 +0000 (18:27 +0100)
Instead of if-else-if, simply call roundup_pow_of_two(BITS_PER_BYTES()).
Note, there is no division assumed as compiler may optimize it away.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230710154932.68377-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi.c

index 6d74218..125dea8 100644 (file)
@@ -3643,13 +3643,7 @@ int spi_split_transfers_maxwords(struct spi_controller *ctlr,
                size_t maxsize;
                int ret;
 
-               if (xfer->bits_per_word <= 8)
-                       maxsize = maxwords;
-               else if (xfer->bits_per_word <= 16)
-                       maxsize = 2 * maxwords;
-               else
-                       maxsize = 4 * maxwords;
-
+               maxsize = maxwords * roundup_pow_of_two(BITS_TO_BYTES(xfer->bits_per_word));
                if (xfer->len > maxsize) {
                        ret = __spi_split_transfer_maxsize(ctlr, msg, &xfer,
                                                           maxsize, gfp);