projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b90cb10
)
spi: mt7621: Fix an error message in mt7621_spi_probe()
author
Christophe JAILLET
<christophe.jaillet@wanadoo.fr>
Sat, 27 Aug 2022 11:42:07 +0000
(13:42 +0200)
committer
Mark Brown
<broonie@kernel.org>
Mon, 29 Aug 2022 16:51:36 +0000
(17:51 +0100)
'status' is known to be 0 at this point. The expected error code is
PTR_ERR(clk).
Switch to dev_err_probe() in order to display the expected error code (in a
human readable way).
This also filters -EPROBE_DEFER cases, should it happen.
Fixes:
1ab7f2a43558
("staging: mt7621-spi: add mt7621 support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Link:
https://lore.kernel.org/r/928f3fb507d53ba0774df27cea0bbba4b055993b.1661599671.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mt7621.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-mt7621.c
b/drivers/spi/spi-mt7621.c
index
b4b9b73
..
351b0ef
100644
(file)
--- a/
drivers/spi/spi-mt7621.c
+++ b/
drivers/spi/spi-mt7621.c
@@
-340,11
+340,9
@@
static int mt7621_spi_probe(struct platform_device *pdev)
return PTR_ERR(base);
clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(clk)) {
- dev_err(&pdev->dev, "unable to get SYS clock, err=%d\n",
- status);
- return PTR_ERR(clk);
- }
+ if (IS_ERR(clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(clk),
+ "unable to get SYS clock\n");
status = clk_prepare_enable(clk);
if (status)