perf diff: Use llabs() with 64-bit values
authorArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 27 Nov 2019 12:58:22 +0000 (09:58 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 28 Nov 2019 11:08:38 +0000 (08:08 -0300)
To fix this build error on a debian mipsel cross build environment:

  builtin-diff.c: In function 'compute_cycles_diff':
  builtin-diff.c:649:10: error: absolute value function 'labs' given an argument of type 's64' {aka 'long long int'} but has parameter of type 'long int' which may cause truncation of value [-Werror=absolute-value]
    649 |    val = labs(pair->block_info->cycles_spark[i] -
        |          ^~~~

Fixes: cebf7d51a6c3 ("perf diff: Report noisy for cycles diff")
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-pn7szy5uw384ntjgk6zckh6a@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-diff.c

index eae8793..f8b6ae5 100644 (file)
@@ -646,7 +646,7 @@ static void compute_cycles_diff(struct hist_entry *he,
                        if (i >= he->block_info->num || i >= NUM_SPARKS)
                                break;
 
-                       val = labs(pair->block_info->cycles_spark[i] -
+                       val = llabs(pair->block_info->cycles_spark[i] -
                                     he->block_info->cycles_spark[i]);
 
                        update_spark_value(pair->diff.svals, NUM_SPARKS,