powerpc/sstep: Cover new VSX instructions under CONFIG_VSX
authorRavi Bangoria <ravi.bangoria@linux.ibm.com>
Sun, 11 Oct 2020 05:09:05 +0000 (10:39 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:53:47 +0000 (11:53 +0100)
[ Upstream commit 1817de2f141c718f1a0ae59927ec003e9b144349 ]

Recently added Power10 prefixed VSX instruction are included
unconditionally in the kernel. If they are executed on a
machine without VSX support, it might create issues. Fix that.
Also fix one mnemonics spelling mistake in comment.

Fixes: 50b80a12e4cc ("powerpc sstep: Add support for prefixed load/stores")
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201011050908.72173-3-ravi.bangoria@linux.ibm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/lib/sstep.c

index bf2cd3d..b18bce1 100644 (file)
@@ -2757,6 +2757,7 @@ int analyse_instr(struct instruction_op *op, const struct pt_regs *regs,
                        case 41:        /* plwa */
                                op->type = MKOP(LOAD, PREFIXED | SIGNEXT, 4);
                                break;
+#ifdef CONFIG_VSX
                        case 42:        /* plxsd */
                                op->reg = rd + 32;
                                op->type = MKOP(LOAD_VSX, PREFIXED, 8);
@@ -2797,13 +2798,14 @@ int analyse_instr(struct instruction_op *op, const struct pt_regs *regs,
                                op->element_size = 16;
                                op->vsx_flags = VSX_CHECK_VEC;
                                break;
+#endif /* CONFIG_VSX */
                        case 56:        /* plq */
                                op->type = MKOP(LOAD, PREFIXED, 16);
                                break;
                        case 57:        /* pld */
                                op->type = MKOP(LOAD, PREFIXED, 8);
                                break;
-                       case 60:        /* stq */
+                       case 60:        /* pstq */
                                op->type = MKOP(STORE, PREFIXED, 16);
                                break;
                        case 61:        /* pstd */