media: pci: saa7164.c: Replace if(cond) BUG with BUG_ON

Fix the following coccinelle reports:

drivers/media/pci/saa7164/saa7164-buffer.c:254:3-6: WARNING: Use BUG_ON
instead of if condition followed by BUG.

drivers/media/pci/saa7164/saa7164-buffer.c:261:3-6: WARNING: Use BUG_ON
instead of if condition followed by BUG.

Found using - Coccinelle (http://coccinelle.lip6.fr)

Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/pci/saa7164/saa7164-buffer.c b/drivers/media/pci/saa7164/saa7164-buffer.c
index 289cb901985bc5038ac67723396d905767867be9..245d9db280aab6abcadaf49edd85382625dc9282 100644 (file)
--- a/drivers/media/pci/saa7164/saa7164-buffer.c
+++ b/drivers/media/pci/saa7164/saa7164-buffer.c
@@ -250,15 +250,14 @@ int saa7164_buffer_cfg_port(struct saa7164_port *port)
        list_for_each_safe(c, n, &port->dmaqueue.list) {
                buf = list_entry(c, struct saa7164_buffer, list);
 
-               if (buf->flags != SAA7164_BUFFER_FREE)
-                       BUG();
+               BUG_ON(buf->flags != SAA7164_BUFFER_FREE);
 
                /* Place the buffer in the h/w queue */
                saa7164_buffer_activate(buf, i);
 
                /* Don't exceed the device maximum # bufs */
-               if (i++ > port->hwcfg.buffercount)
-                       BUG();
+               BUG_ON(i > port->hwcfg.buffercount);
+               i++;
 
        }
        mutex_unlock(&port->dmaqueue_lock);
@@ -302,4 +301,3 @@ void saa7164_buffer_dealloc_user(struct saa7164_user_buffer *buf)
 
        kfree(buf);
 }
-