nvmet-auth: remove some dead code
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 17 Apr 2023 20:41:13 +0000 (22:41 +0200)
committerKeith Busch <kbusch@kernel.org>
Mon, 12 Jun 2023 17:36:59 +0000 (10:36 -0700)
'status' is known to be 0 at the point.
And nvmet_auth_challenge() return a -E<ERROR_CODE> or 0.
So these lines of code should just be removed.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/fabrics-cmd-auth.c

index 7970a76..038032e 100644 (file)
@@ -483,15 +483,6 @@ void nvmet_execute_auth_receive(struct nvmet_req *req)
                        status = NVME_SC_INTERNAL;
                        break;
                }
-               if (status) {
-                       req->sq->dhchap_status = status;
-                       nvmet_auth_failure1(req, d, al);
-                       pr_warn("ctrl %d qid %d: challenge status (%x)\n",
-                               ctrl->cntlid, req->sq->qid,
-                               req->sq->dhchap_status);
-                       status = 0;
-                       break;
-               }
                req->sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_REPLY;
                break;
        case NVME_AUTH_DHCHAP_MESSAGE_SUCCESS1: