staging: rtl8188eu: remove unnecessary call to memset
authorHimanshu Jha <himanshujha199640@gmail.com>
Mon, 28 Aug 2017 11:06:02 +0000 (16:36 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Aug 2017 06:24:04 +0000 (08:24 +0200)
call to memset to assign 0 value immediately after allocating
memory with kzalloc is unnecesaary as kzalloc allocates the memory
filled with 0 value.

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_mlme.c
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

index fde3060..7397167 100644 (file)
@@ -1566,7 +1566,6 @@ int rtw_set_auth(struct adapter *adapter, struct security_priv *psecuritypriv)
                res = _FAIL;
                goto exit;
        }
-       memset(psetauthparm, 0, sizeof(struct setauth_parm));
        psetauthparm->mode = (unsigned char)psecuritypriv->dot11AuthAlgrthm;
        pcmd->cmdcode = _SetAuth_CMD_;
        pcmd->parmbuf = (unsigned char *)psetauthparm;
@@ -1601,8 +1600,6 @@ int rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, in
                goto err_free_cmd;
        }
 
-       memset(psetkeyparm, 0, sizeof(struct setkey_parm));
-
        if (psecuritypriv->dot11AuthAlgrthm == dot11AuthAlgrthm_8021X) {
                psetkeyparm->algorithm = (unsigned char)psecuritypriv->dot118021XGrpPrivacy;
                RT_TRACE(_module_rtl871x_mlme_c_, _drv_err_,
index 763eccd..c0664dc 100644 (file)
@@ -2166,8 +2166,6 @@ static int set_group_key(struct adapter *padapter, u8 *key, u8 alg, int keyid)
                goto exit;
        }
 
-       memset(psetkeyparm, 0, sizeof(struct setkey_parm));
-
        psetkeyparm->keyid = (u8)keyid;
 
        psetkeyparm->algorithm = alg;