net: ethernet: ti: fix return value check in k3_cppi_desc_pool_create_name()

In case of error, the function gen_pool_create() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c b/drivers/net/ethernet/ti/k3-cppi-desc-pool.c
index ad7cfc1316cef45b32488883ecaeab54c805f811..38cc12f9f13324036948be2b6b67b9386fbb1a2d 100644 (file)
--- a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c
+++ b/drivers/net/ethernet/ti/k3-cppi-desc-pool.c
@@ -64,8 +64,8 @@ k3_cppi_desc_pool_create_name(struct device *dev, size_t size,
                return ERR_PTR(-ENOMEM);
 
        pool->gen_pool = gen_pool_create(ilog2(pool->desc_size), -1);
-       if (IS_ERR(pool->gen_pool)) {
-               ret = PTR_ERR(pool->gen_pool);
+       if (!pool->gen_pool) {
+               ret = -ENOMEM;
                dev_err(pool->dev, "pool create failed %d\n", ret);
                kfree_const(pool_name);
                goto gen_pool_create_fail;