Fix resource leak 90/232090/1
authorJusung Son <jusung07.son@samsung.com>
Tue, 28 Apr 2020 06:51:54 +0000 (15:51 +0900)
committerJusung Son <jusung07.son@samsung.com>
Tue, 28 Apr 2020 06:51:54 +0000 (15:51 +0900)
Change-Id: I01c81ce4853be5d56070da78699fc044998613d2
Signed-off-by: Jusung Son <jusung07.son@samsung.com>
unittest/src/test-watchface-editable.cc

index 3101e8b..14ea24f 100644 (file)
@@ -318,13 +318,14 @@ TEST_F(CWE, watchface_editable_candidates_color_test)
   watchface_editable_candidate_get_id(candidate, &id);
   EXPECT_STREQ(id, "test");
   free(id);
+  id = nullptr;
 
   ret = watchface_editable_candidate_get_id(candidate, nullptr);
   EXPECT_EQ(WATCHFACE_COMPLICATION_ERROR_INVALID_PARAMETER, ret);
   bundle *empty_bundle = bundle_create();
   ret = watchface_editable_candidate_get_id(empty_bundle, &id);
   EXPECT_EQ(WATCHFACE_COMPLICATION_ERROR_NO_DATA, ret);
-
+  free(id);
 
   ret = watchface_editable_candidate_color_create(&color, 12, 34, 56, 78);
   EXPECT_EQ(WATCHFACE_COMPLICATION_ERROR_NONE, ret);
@@ -365,6 +366,7 @@ TEST_F(CWE, watchface_editable_candidates_color_test)
   EXPECT_EQ(WATCHFACE_COMPLICATION_ERROR_NONE, ret);
   EXPECT_STREQ(name, "test_name");
   free(name);
+  name = nullptr;
 
   ret = watchface_editable_candidate_set_name(candidate, nullptr);
   EXPECT_EQ(WATCHFACE_COMPLICATION_ERROR_INVALID_PARAMETER, ret);
@@ -377,6 +379,7 @@ TEST_F(CWE, watchface_editable_candidates_color_test)
 
   bundle_free(empty_bundle);
   bundle_free(candidate);
+  free(name);
 }
 
 TEST_F(CWE, watchface_editable_candidates_preview_image_test)
@@ -397,6 +400,7 @@ TEST_F(CWE, watchface_editable_candidates_preview_image_test)
   EXPECT_EQ(WATCHFACE_COMPLICATION_ERROR_NONE, ret);
   EXPECT_STREQ(imagepath, "imagepath");
   free(imagepath);
+  imagepath = nullptr;
 
   ret = watchface_editable_candidate_get_preview_image(candidate, nullptr);
   EXPECT_EQ(WATCHFACE_COMPLICATION_ERROR_INVALID_PARAMETER, ret);
@@ -405,6 +409,7 @@ TEST_F(CWE, watchface_editable_candidates_preview_image_test)
 
   bundle_free(empty_bundle);
   bundle_free(candidate);
+  free(imagepath);
 }
 
 }
\ No newline at end of file