[POWERPC] wrapper: Treat NULL as root node in devp_offset; add devp_offset_find()
authorScott Wood <scottwood@freescale.com>
Tue, 11 Dec 2007 21:23:05 +0000 (08:23 +1100)
committerPaul Mackerras <paulus@samba.org>
Thu, 20 Dec 2007 05:11:46 +0000 (16:11 +1100)
Many operations, as currently used in the wrapper, assume they can
pass NULL and have it be treated as the root node.  However, libfdt-wrapper
converts NULL to -1, which is only appropriate when searching for nodes,
and will cause an error otherwise.

Signed-off-by: Scott Wood <scottwood@freescale.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/boot/libfdt-wrapper.c

index 868c504..97af36c 100644 (file)
@@ -48,7 +48,8 @@
                check_err(_offset) ? NULL : (void *)(_offset+1); \
        })
 
-#define devp_offset(devp)      (((int)(devp))-1)
+#define devp_offset_find(devp) (((int)(devp))-1)
+#define devp_offset(devp)      (devp ? ((int)(devp))-1 : 0)
 
 static void *fdt;
 static void *buf; /* = NULL */
@@ -127,8 +128,9 @@ static void *fdt_wrapper_find_node_by_prop_value(const void *prev,
                                                 const char *val,
                                                 int len)
 {
-       return offset_devp(fdt_node_offset_by_prop_value(fdt, devp_offset(prev),
-                                                        name, val, len));
+       int offset = fdt_node_offset_by_prop_value(fdt, devp_offset_find(prev),
+                                                  name, val, len);
+       return offset_devp(offset);
 }
 
 static char *fdt_wrapper_get_path(const void *devp, char *buf, int len)