Fix a memory leak if parent directory creation failed.
authorMatt Kraai <kraai@debian.org>
Fri, 24 Aug 2001 19:07:31 +0000 (19:07 -0000)
committerMatt Kraai <kraai@debian.org>
Fri, 24 Aug 2001 19:07:31 +0000 (19:07 -0000)
libbb/make_directory.c

index 0a9d7b1..7b7fde9 100644 (file)
@@ -49,16 +49,16 @@ int make_directory (char *path, long mode, int flags)
                struct stat st;
 
                if (stat (path, &st) < 0 && errno == ENOENT) {
+                       int status;
                        char *parent = dirname (path);
                        mode_t mask = umask (0);
                        umask (mask);
 
-                       if (make_directory (parent, (0777 & ~mask) | 0300,
-                                               FILEUTILS_RECUR) < 0)
-                               return -1;
+                       status = make_directory (parent, (0777 & ~mask) | 0300,
+                                       FILEUTILS_RECUR);
                        free (parent);
 
-                       if (make_directory (path, mode, 0) < 0)
+                       if (status < 0 || make_directory (path, mode, 0) < 0)
                                return -1;
                }
        }