tipc: remove duplicated code in tipc_msg_create
authorHoang Huu Le <hoang.h.le@dektech.com.au>
Wed, 27 Jan 2021 02:51:23 +0000 (09:51 +0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 28 Jan 2021 02:50:07 +0000 (18:50 -0800)
Remove a duplicate code checking for header size in tipc_msg_create() as
it's already being done in tipc_msg_init().

Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Huu Le <hoang.h.le@dektech.com.au>
Link: https://lore.kernel.org/r/20210127025123.6390-1-hoang.h.le@dektech.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tipc/msg.c

index 2aca86021df5ab0e0808ab97ee262211fb475650..e9263280a2d4a39fa520fab845a8883c7a4703f6 100644 (file)
@@ -117,10 +117,6 @@ struct sk_buff *tipc_msg_create(uint user, uint type,
        msg_set_origport(msg, oport);
        msg_set_destport(msg, dport);
        msg_set_errcode(msg, errcode);
-       if (hdr_sz > SHORT_H_SIZE) {
-               msg_set_orignode(msg, onode);
-               msg_set_destnode(msg, dnode);
-       }
        return buf;
 }