cpufreq: dt: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 27 Sep 2022 15:40:18 +0000 (23:40 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Tue, 18 Oct 2022 10:52:25 +0000 (16:22 +0530)
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/cpufreq-dt.c

index d69d13a..4aec4b2 100644 (file)
@@ -222,10 +222,8 @@ static int dt_cpufreq_early_init(struct device *dev, int cpu)
        if (reg_name[0]) {
                priv->opp_token = dev_pm_opp_set_regulators(cpu_dev, reg_name);
                if (priv->opp_token < 0) {
-                       ret = priv->opp_token;
-                       if (ret != -EPROBE_DEFER)
-                               dev_err(cpu_dev, "failed to set regulators: %d\n",
-                                       ret);
+                       ret = dev_err_probe(cpu_dev, priv->opp_token,
+                                           "failed to set regulators\n");
                        goto free_cpumask;
                }
        }