media: ov5693: fix boolconv.cocci warnings
authorkernel test robot <lkp@intel.com>
Wed, 19 Jan 2022 05:24:42 +0000 (06:24 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 28 Jan 2022 18:32:49 +0000 (19:32 +0100)
drivers/media/i2c/ov5693.c:989:46-51: WARNING: conversion to bool not needed here
drivers/media/i2c/ov5693.c:991:46-51: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

[Sakari Ailus: Improved subject]

CC: Daniel Scally <djrscally@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ov5693.c

index 2784fcf..4a5aa6e 100644 (file)
@@ -986,9 +986,9 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
 
        mutex_lock(&ov5693->lock);
 
-       ov5693->mode.binning_x = hratio > 1 ? true : false;
+       ov5693->mode.binning_x = hratio > 1;
        ov5693->mode.inc_x_odd = hratio > 1 ? 3 : 1;
-       ov5693->mode.binning_y = vratio > 1 ? true : false;
+       ov5693->mode.binning_y = vratio > 1;
        ov5693->mode.inc_y_odd = vratio > 1 ? 3 : 1;
 
        ov5693->mode.vts = __ov5693_calc_vts(fmt->height);