YaGL: Disable ETC1_RGB8_OES format check 52/62552/1 accepted/tizen/common/20160317.160510 accepted/tizen/ivi/20160317.115702 accepted/tizen/mobile/20160317.115617 accepted/tizen/tv/20160317.115631 accepted/tizen/wearable/20160317.115645 submit/tizen/20160317.020331
authorVasiliy Ulyanov <v.ulyanov@samsung.com>
Wed, 16 Mar 2016 12:34:19 +0000 (15:34 +0300)
committerVasiliy Ulyanov <v.ulyanov@samsung.com>
Wed, 16 Mar 2016 12:43:53 +0000 (15:43 +0300)
OES_compressed_ETC1_RGB8_texture spec says:

    INVALID_OPERATION is generated by CompressedTexSubImage2D,
    TexSubImage2D, or CopyTexSubImage2D if the texture image <level>
    bound to <target> has internal format ETC1_RGB8_OES.

Currently this error check causes problems with some apps so
temporarly disable it as a workaround.

Change-Id: I8bdc6f2b7a7b65730d4dee9a8a91b9f6ce465485
Signed-off-by: Vasiliy Ulyanov <v.ulyanov@samsung.com>
GLESv2/yagl_gles2_context.c

index 515d5f2193d1c2e29edb8440bcc71a897a9a526a..f9591e2dad6e5d85e6a7053802c02e63efd1f318 100644 (file)
@@ -721,6 +721,12 @@ void yagl_gles2_context_compressed_tex_sub_image_2d(struct yagl_gles_context *gl
 
     YAGL_LOG_FUNC_SET(glCompressedTexSubImage2D);
 
+#if 0
+    /*
+     * FIXME: this is a workaround. GL_ETC1_RGB8_OES check is absolutely
+     * correct according to the spec. Unfortunately at the moment it causes
+     * issues which need to be fixed urgently :(
+     */
     if (format == GL_ETC1_RGB8_OES) {
         /*
          * "INVALID_OPERATION is generated by CompressedTexSubImage2D,
@@ -730,6 +736,7 @@ void yagl_gles2_context_compressed_tex_sub_image_2d(struct yagl_gles_context *gl
         YAGL_SET_ERR(GL_INVALID_OPERATION);
         return;
     }
+#endif /* 0 */
 
     tc_format = yagl_texcompress_get_format(format);