gldeinterlace: remove dead code accessing filter->in_tex_id
authorMatthew Waters <matthew@centricular.com>
Wed, 15 Jun 2016 05:08:39 +0000 (15:08 +1000)
committerTim-Philipp Müller <tim@centricular.com>
Sat, 9 Dec 2017 19:32:20 +0000 (19:32 +0000)
It's not set by anyone or anything and gldeinterlace is the only user of it now.

ext/gl/gstgldeinterlace.c

index bacd1d7cb037c398f96d85c2d0572e3647d96657..c1429a98abafb3afbe43a21c44b7d881df0d50dd 100644 (file)
@@ -469,7 +469,6 @@ gst_gl_deinterlace_greedyh_callback (gint width, gint height, guint texture,
   GstGLDeinterlace *deinterlace_filter = GST_GL_DEINTERLACE (filter);
   GstGLContext *context = GST_GL_BASE_FILTER (filter)->context;
   GstGLFuncs *gl = context->gl_vtable;
-  guint temp;
 
   shader =
       gst_gl_deinterlace_get_fragment_shader (filter, "greedhy",
@@ -487,13 +486,7 @@ gst_gl_deinterlace_greedyh_callback (gint width, gint height, guint texture,
 
   gst_gl_shader_use (shader);
 
-  if (G_UNLIKELY (deinterlace_filter->prev_tex == 0)) {
-    gst_gl_context_gen_texture (GST_GL_BASE_FILTER (filter)->context,
-        &deinterlace_filter->prev_tex,
-        GST_VIDEO_INFO_FORMAT (&filter->out_info),
-        GST_VIDEO_INFO_WIDTH (&filter->out_info),
-        GST_VIDEO_INFO_HEIGHT (&filter->out_info));
-  } else {
+  if (G_LIKELY (deinterlace_filter->prev_tex != 0)) {
     gl->ActiveTexture (GL_TEXTURE1);
     gst_gl_shader_set_uniform_1i (shader, "tex_prev", 1);
     gl->BindTexture (GL_TEXTURE_2D, deinterlace_filter->prev_tex);
@@ -514,11 +507,6 @@ gst_gl_deinterlace_greedyh_callback (gint width, gint height, guint texture,
 
   gst_gl_filter_draw_texture (filter, texture, width, height);
 
-  if (texture == filter->in_tex_id) {
-    temp = filter->in_tex_id;
-    filter->in_tex_id = deinterlace_filter->prev_tex;
-    deinterlace_filter->prev_tex = temp;
-  } else {
-    deinterlace_filter->prev_tex = texture;
-  }
+  /* we keep the previous buffer around so this is safe */
+  deinterlace_filter->prev_tex = texture;
 }