playsink: improve GL context sharing

Configure playsink tried element with the bus of the main pipeline.
That tried element can be a gl video sink, which would benefit from being
able to propagate context messages to the main pipeline and have other
internal pipeline elements configured with it. Having different elements
configured with the same GL context allows them to share buffers with
video/x-raw(memory:GLMemory) caps and achieving zero-copy.

Thanks to Alicia Boya García <aboya@igalia.com> for her work co-debugging
the issue and contributing to find a solution.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2056>

diff --git a/subprojects/gst-plugins-base/gst/playback/gstplaysink.c b/subprojects/gst-plugins-base/gst/playback/gstplaysink.c
index 31251d6..a870613 100644 (file)
--- a/subprojects/gst-plugins-base/gst/playback/gstplaysink.c
+++ b/subprojects/gst-plugins-base/gst/playback/gstplaysink.c
@@ -1471,11 +1471,18 @@ static GstElement *
 try_element (GstPlaySink * playsink, GstElement * element, gboolean unref)
 {
   GstStateChangeReturn ret;
+  GstBus *element_bus;
 
   if (element) {
+    element_bus = gst_element_get_bus (element);
+    g_assert (!element_bus);
+    gst_element_set_bus (element, GST_BIN_CAST (playsink)->child_bus);
+
     ret = gst_element_set_state (element, GST_STATE_READY);
+
     if (ret == GST_STATE_CHANGE_FAILURE) {
       GST_DEBUG_OBJECT (playsink, "failed state change..");
+      gst_element_set_bus (element, NULL);
       gst_element_set_state (element, GST_STATE_NULL);
       if (unref)
         gst_object_unref (element);