i2c: qcom-geni: remove unnecessary conditions
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 7 Mar 2022 12:56:03 +0000 (15:56 +0300)
committerWolfram Sang <wsa@kernel.org>
Sat, 21 May 2022 10:28:10 +0000 (12:28 +0200)
We know that "ret" is a negative error code at this point so there is
no need to check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-qcom-geni.c

index fc1dcc1..17915c9 100644 (file)
@@ -727,16 +727,14 @@ static int setup_gpi_dma(struct geni_i2c_dev *gi2c)
        if (IS_ERR(gi2c->tx_c)) {
                ret = dev_err_probe(gi2c->se.dev, PTR_ERR(gi2c->tx_c),
                                    "Failed to get tx DMA ch\n");
-               if (ret < 0)
-                       goto err_tx;
+               goto err_tx;
        }
 
        gi2c->rx_c = dma_request_chan(gi2c->se.dev, "rx");
        if (IS_ERR(gi2c->rx_c)) {
                ret = dev_err_probe(gi2c->se.dev, PTR_ERR(gi2c->rx_c),
                                    "Failed to get rx DMA ch\n");
-               if (ret < 0)
-                       goto err_rx;
+               goto err_rx;
        }
 
        dev_dbg(gi2c->se.dev, "Grabbed GPI dma channels\n");