drm/amd/amdgpu: Fix warnings in amdgpu_encoders.c
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Wed, 17 May 2023 13:08:00 +0000 (18:38 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Jun 2023 14:38:09 +0000 (10:38 -0400)
Fix below checkpatch warnings:

WARNING: Missing a blank line after declarations
+                       struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
+                       amdgpu_encoder->active_device = amdgpu_encoder->devices & amdgpu_connector->devices;

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Acked-by: Luben Tuikov <luben.tuikov@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c

index 27a782a..3aaeed2 100644 (file)
@@ -70,6 +70,7 @@ void amdgpu_encoder_set_active_device(struct drm_encoder *encoder)
        drm_for_each_connector_iter(connector, &iter) {
                if (connector->encoder == encoder) {
                        struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
+
                        amdgpu_encoder->active_device = amdgpu_encoder->devices & amdgpu_connector->devices;
                        DRM_DEBUG_KMS("setting active device to %08x from %08x %08x for encoder %d\n",
                                  amdgpu_encoder->active_device, amdgpu_encoder->devices,
@@ -165,12 +166,12 @@ void amdgpu_panel_mode_fixup(struct drm_encoder *encoder,
 {
        struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
        struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
-       unsigned hblank = native_mode->htotal - native_mode->hdisplay;
-       unsigned vblank = native_mode->vtotal - native_mode->vdisplay;
-       unsigned hover = native_mode->hsync_start - native_mode->hdisplay;
-       unsigned vover = native_mode->vsync_start - native_mode->vdisplay;
-       unsigned hsync_width = native_mode->hsync_end - native_mode->hsync_start;
-       unsigned vsync_width = native_mode->vsync_end - native_mode->vsync_start;
+       unsigned int hblank = native_mode->htotal - native_mode->hdisplay;
+       unsigned int vblank = native_mode->vtotal - native_mode->vdisplay;
+       unsigned int hover = native_mode->hsync_start - native_mode->hdisplay;
+       unsigned int vover = native_mode->vsync_start - native_mode->vdisplay;
+       unsigned int hsync_width = native_mode->hsync_end - native_mode->hsync_start;
+       unsigned int vsync_width = native_mode->vsync_end - native_mode->vsync_start;
 
        adjusted_mode->clock = native_mode->clock;
        adjusted_mode->flags = native_mode->flags;