pinctrl: bcm2835: Replace BUG with BUG_ON
authorJason Wang <wangborong@cdjrlc.com>
Thu, 24 Jun 2021 06:49:13 +0000 (14:49 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 23 Jul 2021 15:47:00 +0000 (17:47 +0200)
The if condition followed by BUG can be replaced to BUG_ON which is
more compact and formal in linux source.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20210624064913.41788-1-wangborong@cdjrlc.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-bcm2835.c

index 2c87af1..8440c72 100644 (file)
@@ -416,8 +416,7 @@ static void bcm2835_gpio_irq_handler(struct irq_desc *desc)
                }
        }
        /* This should not happen, every IRQ has a bank */
-       if (i == BCM2835_NUM_IRQS)
-               BUG();
+       BUG_ON(i == BCM2835_NUM_IRQS);
 
        chained_irq_enter(host_chip, desc);