edje_cc: fix dereference before null check
authorjiin.moon <jiin.moon@samsung.com>
Mon, 27 Jul 2015 22:46:05 +0000 (00:46 +0200)
committerCedric BAIL <cedric@osg.samsung.com>
Tue, 28 Jul 2015 01:05:37 +0000 (03:05 +0200)
Summary:
Fix Coverity issue which reports a dereference before null check.
The enc_info can not has NULL point
because _edje_multisense_encode api calls exit() in case of failure

Reviewers: Hermet, Jaehyun, cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2794

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
src/bin/edje/edje_cc_out.c

index 24066ad..f96e2f3 100755 (executable)
@@ -1152,7 +1152,7 @@ data_thread_sounds(void *data, Ecore_Thread *thread EINA_UNUSED)
 #ifdef HAVE_LIBSNDFILE
    if ((enc_info->file) && (!enc_info->encoded))
      eina_stringshare_del(enc_info->file);
-   if (enc_info) free(enc_info);
+   free(enc_info);
    enc_info = NULL;
 #endif
 }