usb: cdns3: remove dead code
authorDongliang Mu <mudongliangabcd@gmail.com>
Mon, 26 Sep 2022 13:59:21 +0000 (21:59 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Sep 2022 08:36:36 +0000 (10:36 +0200)
Smatch reports the following error:

drivers/usb/cdns3/cdns3-plat.c:113 cdns3_plat_probe() warn:
platform_get_irq() does not return zero

From the document, platform_get_irq_byname_optional only returns
non-zero value, and negative value on failure.

Fix this by removing the zero value checking.

Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Link: https://lore.kernel.org/r/20220926135922.24541-1-dzm91@hust.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/cdns3-plat.c

index dc068e9..2bc5d09 100644 (file)
@@ -110,8 +110,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
        cdns->wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup");
        if (cdns->wakeup_irq == -EPROBE_DEFER)
                return cdns->wakeup_irq;
-       else if (cdns->wakeup_irq == 0)
-               return -EINVAL;
 
        if (cdns->wakeup_irq < 0) {
                dev_dbg(dev, "couldn't get wakeup irq\n");