amdgpu: Don't use DRM_ERROR when failing to allocate a BO
authorMichel Dänzer <michel.daenzer@amd.com>
Wed, 15 Nov 2017 10:37:23 +0000 (11:37 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 6 Dec 2017 17:47:49 +0000 (12:47 -0500)
This can be triggered by userspace, e.g. trying to allocate too large a
BO, so it shouldn't log anything by default.

Callers need to handle failure anyway.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

index e87eedc..3ad4cf0 100644 (file)
@@ -72,7 +72,7 @@ retry:
                                initial_domain |= AMDGPU_GEM_DOMAIN_GTT;
                                goto retry;
                        }
-                       DRM_ERROR("Failed to allocate GEM object (%ld, %d, %u, %d)\n",
+                       DRM_DEBUG("Failed to allocate GEM object (%ld, %d, %u, %d)\n",
                                  size, initial_domain, alignment, r);
                }
                return r;
index 5acf20c..3233d59 100644 (file)
@@ -314,8 +314,8 @@ static bool amdgpu_bo_validate_size(struct amdgpu_device *adev,
        return true;
 
 fail:
-       DRM_ERROR("BO size %lu > total memory in domain: %llu\n", size,
-                                             man->size << PAGE_SHIFT);
+       DRM_DEBUG("BO size %lu > total memory in domain: %llu\n", size,
+                 man->size << PAGE_SHIFT);
        return false;
 }