staging: kpc2000: kpc_i2c: Use devm_* API to manage mapped I/O space
authorGeordan Neukum <gneukum1@gmail.com>
Sun, 26 May 2019 01:18:34 +0000 (01:18 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2019 21:04:26 +0000 (14:04 -0700)
The kpc_i2c driver does not unmap its I/O space upon error cases in the
probe() function or upon remove(). Make the driver clean up after itself
more maintainably by using the managed resource API.

Signed-off-by: Geordan Neukum <gneukum1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_i2c.c

index 51e9165..a434dd0 100644 (file)
@@ -590,7 +590,9 @@ static int pi2c_probe(struct platform_device *pldev)
        if (!res)
                return -ENXIO;
 
-       priv->smba = (unsigned long)ioremap_nocache(res->start, resource_size(res));
+       priv->smba = (unsigned long)devm_ioremap_nocache(&pldev->dev,
+                                                        res->start,
+                                                        resource_size(res));
        if (!priv->smba)
                return -ENOMEM;