projects
/
platform
/
upstream
/
sysprof.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ded3754
)
Add FIXME about performance issue in stack_stash_add_trace()
author
Søren Sandmann Pedersen
<sandmann@daimi.au.dk>
Fri, 23 Apr 2010 15:26:17 +0000
(11:26 -0400)
committer
Søren Sandmann Pedersen
<sandmann@daimi.au.dk>
Fri, 23 Apr 2010 15:56:14 +0000
(11:56 -0400)
stackstash.c
patch
|
blob
|
history
diff --git
a/stackstash.c
b/stackstash.c
index
8c06f7b
..
44912e4
100644
(file)
--- a/
stackstash.c
+++ b/
stackstash.c
@@
-220,6
+220,13
@@
stack_stash_add_trace (StackStash *stash,
StackNode *match = NULL;
StackNode *prev;
+ /* FIXME: On x86-64 we don't get proper stacktraces which means
+ * each node can have tons of children. That makes this loop
+ * here show up on profiles.
+ *
+ * Not sure what can be done about it aside from actually fixing
+ * x86-64 to get stacktraces.
+ */
prev = NULL;
for (match = *location; match; prev = match, match = match->siblings)
{