isl: program 3DSTATE_HIER_DEPTH_BUFFER_BODY::TiledMode as documented
authorLionel Landwerlin <lionel.g.landwerlin@intel.com>
Mon, 19 Jun 2023 13:38:24 +0000 (16:38 +0300)
committerMarge Bot <emma+marge@anholt.net>
Fri, 1 Sep 2023 23:22:17 +0000 (23:22 +0000)
Since this value is 0, it doesn't change anything, but it's just good
practice like we did for Gfx12.5 right above.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23620>

src/intel/isl/isl_emit_depth_stencil.c

index aaa2a8e..da03391 100644 (file)
@@ -299,6 +299,19 @@ isl_genX(emit_depth_stencil_hiz_s)(const struct isl_device *dev, void *batch,
        */
       assert(info->hiz_surf->tiling == ISL_TILING_HIZ);
       hiz.TiledMode = TILE4;
+#elif GFX_VERx10 >= 120
+      /* From 3DSTATE_HIER_DEPTH_BUFFER_BODY::TiledMode,
+       *
+       *     HZ buffer only supports Tile Y mode.
+       *
+       * and
+       *
+       *    Value | Name
+       *    ----------------------------------------
+       *    0h    | No tiled resource (Tile Y Mode).
+       */
+      assert(info->hiz_surf->tiling == ISL_TILING_HIZ);
+      hiz.TiledMode = NONE;
 #endif
 
 #if GFX_VER >= 12