octeon_ep: delete unnecessary napi rollback under set_queues_err in octep_open()
authorZiyang Xuan <william.xuanziyang@huawei.com>
Fri, 11 Nov 2022 07:08:27 +0000 (15:08 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Nov 2022 10:55:43 +0000 (10:55 +0000)
octep_napi_add() and octep_napi_enable() are all after
netif_set_real_num_{tx,rx}_queues() in octep_open(), so it is unnecessary
napi rollback under set_queues_err. Delete them to fix it.

Fixes: 37d79d059606 ("octeon_ep: add Tx/Rx processing and interrupt support")
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/octeon_ep/octep_main.c

index 9089adc..7985a74 100644 (file)
@@ -527,8 +527,6 @@ static int octep_open(struct net_device *netdev)
        return 0;
 
 set_queues_err:
-       octep_napi_disable(oct);
-       octep_napi_delete(oct);
        octep_clean_irqs(oct);
 setup_irq_err:
        octep_free_oqs(oct);