core-util: don't leak memory in pa_unset_env_recorded()
authorLennart Poettering <lennart@poettering.net>
Wed, 2 Sep 2009 02:05:34 +0000 (04:05 +0200)
committerLennart Poettering <lennart@poettering.net>
Wed, 2 Sep 2009 02:05:34 +0000 (04:05 +0200)
src/pulsecore/core-util.c

index 9034dc3..a3c6013 100644 (file)
@@ -2474,9 +2474,11 @@ void pa_unset_env_recorded(void) {
     /* This is not thread-safe */
 
     for (;;) {
-        char *s = NULL;
+        char *s;
 
-        if (!(recorded_env = pa_strlist_pop(recorded_env, &s)))
+        recorded_env = pa_strlist_pop(recorded_env, &s);
+
+        if (!s)
             break;
 
         unsetenv(s);