echo-cancel: Fix coverity issues (PARAMETER_HIDDEN)

[Version] 15.0.24
[Issue Type] Coverity

Change-Id: Ia5f389a408b7bb97ab379215939d9b910aebb8ee
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>

diff --git a/packaging/pulseaudio-modules-tizen.spec b/packaging/pulseaudio-modules-tizen.spec
index 2eae259..ad23656 100644 (file)
--- a/packaging/pulseaudio-modules-tizen.spec
+++ b/packaging/pulseaudio-modules-tizen.spec
@@ -2,7 +2,7 @@
 
 Name:             pulseaudio-modules-tizen
 Summary:          Pulseaudio modules for Tizen
-Version:          15.0.22
+Version:          15.0.24
 Release:          0
 Group:            Multimedia/Audio
 License:          LGPL-2.1+

diff --git a/src/echo-cancel/module-tizenaudio-echo-cancel.c b/src/echo-cancel/module-tizenaudio-echo-cancel.c
index 7697368..4b6939b 100644 (file)
--- a/src/echo-cancel/module-tizenaudio-echo-cancel.c
+++ b/src/echo-cancel/module-tizenaudio-echo-cancel.c
@@ -295,29 +295,29 @@ static int process_msg(
         pa_memchunk *chunk) {
 
     struct userdata *u = PA_ECHO_CANCEL(o)->u;
+    pa_source_output *so = NULL;
 
     /* trigger resolves a race condition related to post_process between source and render thread */
     if (u->triggered) {
         if (code == PA_ECHO_CANCEL_MESSAGE_PUSH_ECHO) {
-            pa_source_output *o = NULL;
             pa_usec_t latency;
 
-            o = find_source_output_by_flags(u->source);
-            if (!o) {
+            so = find_source_output_by_flags(u->source);
+            if (!so) {
                 u->triggered = false;
                 return 0;
             }
 
-            o->post_process = post_process;
+            so->post_process = post_process;
 
             latency = get_round_trip_latency(u);
 
-            if (pa_processor_setup_reference_memblockq_padding(o->thread_info.processor, latency) < 0)
+            if (pa_processor_setup_reference_memblockq_padding(so->thread_info.processor, latency) < 0)
                 pa_log_warn("Failed to setup reference memblockq padding");
 
             u->triggered = false;
 
-            pa_log_info("Triggered Echo-Cancellation. index(%d), latency(%" PRIu64 ") usec", o->index, latency);
+            pa_log_info("Triggered Echo-Cancellation. index(%d), latency(%" PRIu64 ") usec", so->index, latency);
         }
     }
 
@@ -330,15 +330,13 @@ static int process_msg(
             break;
         case PA_ECHO_CANCEL_MESSAGE_PUSH_ECHO:
             if (u->enable_in_thread) {
-                pa_source_output *o = NULL;
-
                 pa_assert(u->source);
 
-                o = find_source_output_by_flags(u->source);
-                if (!o)
+                so = find_source_output_by_flags(u->source);
+                if (!so)
                     break;
 
-                if (pa_processor_push_reference(o->thread_info.processor, chunk) < 0)
+                if (pa_processor_push_reference(so->thread_info.processor, chunk) < 0)
                     pa_log_error("Failed to push reference data");
             }
 
@@ -346,15 +344,15 @@ static int process_msg(
         case PA_ECHO_CANCEL_MESSAGE_SET_AEC_STATE: {
             void **v = (void **)data;
             bool enable = (bool)v[0];
-            pa_source_output *o = (pa_source_output *)v[1];
+            so = (pa_source_output *)v[1];
 
             u->enable_in_thread = enable;
 
             if (enable) {
                 u->triggered = true;
             } else {
-                pa_processor_flush(o->thread_info.processor);
-                o->post_process = NULL;
+                pa_processor_flush(so->thread_info.processor);
+                so->post_process = NULL;
             }
 
             break;