Fix NULL pointer deferencing in policyengine.
authorSatya Prakash Gupta <sp.gupta@samsung.com>
Thu, 18 Jun 2015 12:41:56 +0000 (18:11 +0530)
committerSachin Agrawal <sachin.agrawal@intel.com>
Fri, 19 Jun 2015 16:55:13 +0000 (16:55 +0000)
Update ProcessAccessRequest to call IsAccessGranted only when context is
not NULL.

Change-Id: I63abb58f254a5080ba46b30203f1e43fa6b2e781
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1359
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
resource/csdk/security/src/policyengine.c

index 28ece4a..c9f6aa0 100644 (file)
@@ -259,17 +259,24 @@ void ProcessAccessRequest(PEContext_t *context)
             }
         }
         while((NULL != currentAcl) && (false == context->matchingAclFound));
-    }
-    if(IsAccessGranted(context->retVal))
-    {
-        OC_LOG(INFO, TAG, PCF("ProcessAccessRequest(): \
-            Leaving ProcessAccessRequest(ACCESS_GRANTED)"));
+
+        if(IsAccessGranted(context->retVal))
+        {
+            OC_LOG(INFO, TAG, PCF("ProcessAccessRequest(): \
+                Leaving ProcessAccessRequest(ACCESS_GRANTED)"));
+        }
+        else
+        {
+            OC_LOG(INFO, TAG, PCF("ProcessAccessRequest(): \
+                Leaving ProcessAccessRequest(ACCESS_DENIED)"));
+        }
     }
     else
     {
         OC_LOG(INFO, TAG, PCF("ProcessAccessRequest(): \
-            Leaving ProcessAccessRequest(ACCESS_DENIED)"));
+            Leaving ProcessAccessRequest(context is NULL)"));
     }
+
 }
 
 /**