vhost/scsi: fix up req type endian-ness
authorMichael S. Tsirkin <mst@redhat.com>
Fri, 10 Jul 2020 10:36:16 +0000 (06:36 -0400)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 29 Jul 2020 17:24:30 +0000 (13:24 -0400)
vhost/scsi doesn't handle type conversion correctly
for request type when using virtio 1.0 and up for BE,
or cross-endian platforms.

Fix it up using vhost_32_to_cpu.

Cc: stable@vger.kernel.org
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
drivers/vhost/scsi.c

index 6fb4d7ecfa19fe3de5f44869bddc527ec792d4ee..b22adf03f58425bf3969fbb6df7496ea2c277963 100644 (file)
@@ -1215,7 +1215,7 @@ vhost_scsi_ctl_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq)
                        continue;
                }
 
-               switch (v_req.type) {
+               switch (vhost32_to_cpu(vq, v_req.type)) {
                case VIRTIO_SCSI_T_TMF:
                        vc.req = &v_req.tmf;
                        vc.req_size = sizeof(struct virtio_scsi_ctrl_tmf_req);