+2012-07-19 Diego Novillo <dnovillo@google.com>
+
+ * testsuite-management/validate_failures.py (CollectSumFiles):
+ Rename from GetSumFiles.
+ (GetSumFiles): Factor out of CheckExpectedResults.
+ (CheckExpectedResults): Call it.
+ (ProduceManifest): Call it.
+
2012-07-18 Diego Novillo <dnovillo@google.com>
* testsuite-management/validate_failures.py: Fix
return set()
-def GetSumFiles(builddir):
+def CollectSumFiles(builddir):
sum_files = []
for root, dirs, files in os.walk(builddir):
if '.svn' in dirs:
print result
+def GetSumFiles(results, build_dir):
+ if not results:
+ print 'Getting actual results from build'
+ sum_files = CollectSumFiles(build_dir)
+ else:
+ print 'Getting actual results from user-provided results'
+ sum_files = results.split()
+ return sum_files
+
+
def CheckExpectedResults(options):
if not options.manifest:
(srcdir, target, valid_build) = GetBuildData(options)
print 'Manifest: %s' % manifest_name
manifest = GetManifest(manifest_name)
-
- if not options.results:
- print 'Getting actual results from build'
- sum_files = GetSumFiles(options.build_dir)
- else:
- print 'Getting actual results from user-provided results'
- sum_files = options.results.split()
+ sum_files = GetSumFiles(options.results, options.build_dir)
actual = GetResults(sum_files)
if options.verbosity >= 1:
Error('Manifest file %s already exists.\nUse --force to overwrite.' %
manifest_name)
- actual = GetResults(options.build_dir)
+ sum_files = GetSumFiles(options.results, options.build_dir)
+ actual = GetResults(sum_files)
with open(manifest_name, 'w') as manifest_file:
for result in sorted(actual):
print result