Applied review comments.
authorAndrzej Krawczyk <a.krawczyk@samsung.com>
Tue, 3 Aug 2021 11:18:08 +0000 (13:18 +0200)
committerPiotr Czaja <p.czaja@samsung.com>
Tue, 14 Sep 2021 11:01:34 +0000 (13:01 +0200)
Fitness/Views/Converters/WorkoutStateToBoolConverter.cs [deleted file]
Fitness/Views/ExercisingView.xaml.cs

diff --git a/Fitness/Views/Converters/WorkoutStateToBoolConverter.cs b/Fitness/Views/Converters/WorkoutStateToBoolConverter.cs
deleted file mode 100644 (file)
index b394c04..0000000
+++ /dev/null
@@ -1,26 +0,0 @@
-using System;
-using System.Globalization;
-using Tizen.NUI.Binding;
-
-namespace Fitness.Views.Converters
-{
-    public class WorkoutStateToBoolConverter : IValueConverter
-    {
-        public static WorkoutStateToBoolConverter Converter => new WorkoutStateToBoolConverter();
-
-        public object Convert(object value, Type targetType, object parameter, System.Globalization.CultureInfo culture)
-        {
-            if (value is Models.WorkoutState state)
-            {
-                return state == Models.WorkoutState.Playing;
-            }
-
-            return false;
-        }
-
-        public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
-        {
-            throw new NotImplementedException();
-        }
-    }
-}
index 65c69e3d115a46867a1d9a10959bb670745505ac..a81eadca1cdcdaffb1510c94d2b43bed8782d5c0 100644 (file)
@@ -23,6 +23,7 @@ namespace Fitness.Views
             propertyChanged: OnWorkoutStateChanged);
 
         private const int TransitionTime = 500;
+        private const string UnhandledWorkoutStateMessage = "Unhandled workout state.";
         private CancellationTokenSource source;
         private bool isInitialized = false;
         private (Coordinates Preview, Coordinates Camera) playing;
@@ -139,28 +140,28 @@ namespace Fitness.Views
             switch (newState)
             {
                 case WorkoutState.Loading:
-                    _ = ExecuteLoadingSate(oldState);
+                    _ = ExecuteLoadingState(oldState);
                     break;
 
                 case WorkoutState.Playing:
-                    _ = ExecutePlayingSate(oldState);
+                    _ = ExecutePlayingState(oldState);
                     break;
 
                 case WorkoutState.OnHold:
-                    ExecuteOnHoldSate(oldState);
+                    ExecuteOnHoldState(oldState);
                     break;
 
                 case WorkoutState.Paused:
-                    _ = ExecutePausedSate(oldState);
+                    _ = ExecutePausedState(oldState);
                     break;
 
                 default:
-                    Services.Logger.Warn("unhandled workout state");
+                    Services.Logger.Warn(UnhandledWorkoutStateMessage);
                     break;
             }
         }
 
-        private async Task ExecuteLoadingSate(WorkoutState oldState)
+        private async Task ExecuteLoadingState(WorkoutState oldState)
         {
             Preview.Stop();
             LoadingView.Show();
@@ -187,7 +188,7 @@ namespace Fitness.Views
                     break;
 
                 default:
-                    Services.Logger.Warn("unhandled workout state");
+                    Services.Logger.Warn(UnhandledWorkoutStateMessage);
                     break;
             }
 
@@ -195,7 +196,7 @@ namespace Fitness.Views
             LoadingView.Loaded += OnLoaded;
         }
 
-        private async Task ExecutePlayingSate(WorkoutState oldState)
+        private async Task ExecutePlayingState(WorkoutState oldState)
         {
             switch (oldState)
             {
@@ -220,14 +221,14 @@ namespace Fitness.Views
                     break;
 
                 default:
-                    Services.Logger.Warn("unhandled workout state");
+                    Services.Logger.Warn(UnhandledWorkoutStateMessage);
                     break;
             }
 
             Preview.Play();
         }
 
-        private void ExecuteOnHoldSate(WorkoutState oldState)
+        private void ExecuteOnHoldState(WorkoutState oldState)
         {
             switch (oldState)
             {
@@ -236,12 +237,12 @@ namespace Fitness.Views
                     break;
 
                 default:
-                    Services.Logger.Warn("unhandled workout state");
+                    Services.Logger.Warn(UnhandledWorkoutStateMessage);
                     break;
             }
         }
 
-        private async Task ExecutePausedSate(WorkoutState oldState)
+        private async Task ExecutePausedState(WorkoutState oldState)
         {
             switch (oldState)
             {
@@ -264,7 +265,7 @@ namespace Fitness.Views
                     break;
 
                 default:
-                    Services.Logger.Warn("unhandled workout state");
+                    Services.Logger.Warn(UnhandledWorkoutStateMessage);
                     break;
             }
         }