projects
/
platform
/
kernel
/
linux-exynos.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
fddedd8
)
usb: gadget: u_uac1: NULL dereference on error path
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 28 Feb 2013 04:44:38 +0000
(07:44 +0300)
committer
Felipe Balbi
<balbi@ti.com>
Mon, 4 Mar 2013 11:16:45 +0000
(13:16 +0200)
We should return here with an error code instead of continuing.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/u_uac1.c
patch
|
blob
|
history
diff --git
a/drivers/usb/gadget/u_uac1.c
b/drivers/usb/gadget/u_uac1.c
index
e0c5e88
..
c7d460f
100644
(file)
--- a/
drivers/usb/gadget/u_uac1.c
+++ b/
drivers/usb/gadget/u_uac1.c
@@
-240,8
+240,11
@@
static int gaudio_open_snd_dev(struct gaudio *card)
snd = &card->playback;
snd->filp = filp_open(fn_play, O_WRONLY, 0);
if (IS_ERR(snd->filp)) {
+ int ret = PTR_ERR(snd->filp);
+
ERROR(card, "No such PCM playback device: %s\n", fn_play);
snd->filp = NULL;
+ return ret;
}
pcm_file = snd->filp->private_data;
snd->substream = pcm_file->substream;