projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f44e6a3
)
scsi: libcxgbi: fix NULL pointer dereference in cxgbi_device_destroy()
author
Varun Prakash
<varun@chelsio.com>
Wed, 18 Dec 2019 13:45:31 +0000
(19:15 +0530)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Fri, 17 Jan 2020 18:49:03 +0000
(19:49 +0100)
[ Upstream commit
71482fde704efdd8c3abe0faf34d922c61e8d76b
]
If cxgb4i_ddp_init() fails then cdev->cdev2ppm will be NULL, so add a check
for NULL pointer before dereferencing it.
Link:
https://lore.kernel.org/r/1576676731-3068-1-git-send-email-varun@chelsio.com
Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/cxgbi/libcxgbi.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/cxgbi/libcxgbi.c
b/drivers/scsi/cxgbi/libcxgbi.c
index
3e17af8
..
2cd2761
100644
(file)
--- a/
drivers/scsi/cxgbi/libcxgbi.c
+++ b/
drivers/scsi/cxgbi/libcxgbi.c
@@
-121,7
+121,8
@@
static inline void cxgbi_device_destroy(struct cxgbi_device *cdev)
"cdev 0x%p, p# %u.\n", cdev, cdev->nports);
cxgbi_hbas_remove(cdev);
cxgbi_device_portmap_cleanup(cdev);
- cxgbi_ppm_release(cdev->cdev2ppm(cdev));
+ if (cdev->cdev2ppm)
+ cxgbi_ppm_release(cdev->cdev2ppm(cdev));
if (cdev->pmap.max_connect)
cxgbi_free_big_mem(cdev->pmap.port_csk);
kfree(cdev);