gpio: omap: Remove redundant dev_err_probe() and zero value handle code

There is no need to call the dev_err_probe() function directly to print
a custom message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.

And the code to handle bank->irq = 0 is redundant because
platform_get_irq() do not return 0.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 2b78fde..a927680 100644 (file)
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1412,11 +1412,8 @@ static int omap_gpio_probe(struct platform_device *pdev)
        bank->dev = dev;
 
        bank->irq = platform_get_irq(pdev, 0);
-       if (bank->irq <= 0) {
-               if (!bank->irq)
-                       bank->irq = -ENXIO;
-               return dev_err_probe(dev, bank->irq, "can't get irq resource\n");
-       }
+       if (bank->irq < 0)
+               return bank->irq;
 
        bank->chip.parent = dev;
        bank->chip.owner = THIS_MODULE;