spi: spi-rspi: : use proper DMAENGINE API for termination
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Wed, 23 Jun 2021 09:58:42 +0000 (11:58 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 23 Jun 2021 15:33:52 +0000 (16:33 +0100)
dmaengine_terminate_all() is deprecated in favor of explicitly saying if
it should be sync or async. Here, we want dmaengine_terminate_sync()
because there is no other synchronization code in the driver to handle
an async case.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20210623095843.3228-2-wsa+renesas@sang-engineering.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-rspi.c

index e39fd38..d16ed88 100644 (file)
@@ -618,9 +618,9 @@ static int rspi_dma_transfer(struct rspi_data *rspi, struct sg_table *tx,
                        ret = -ETIMEDOUT;
                }
                if (tx)
-                       dmaengine_terminate_all(rspi->ctlr->dma_tx);
+                       dmaengine_terminate_sync(rspi->ctlr->dma_tx);
                if (rx)
-                       dmaengine_terminate_all(rspi->ctlr->dma_rx);
+                       dmaengine_terminate_sync(rspi->ctlr->dma_rx);
        }
 
        rspi_disable_irq(rspi, irq_mask);
@@ -634,7 +634,7 @@ static int rspi_dma_transfer(struct rspi_data *rspi, struct sg_table *tx,
 
 no_dma_tx:
        if (rx)
-               dmaengine_terminate_all(rspi->ctlr->dma_rx);
+               dmaengine_terminate_sync(rspi->ctlr->dma_rx);
 no_dma_rx:
        if (ret == -EAGAIN) {
                dev_warn_once(&rspi->ctlr->dev,