tracing/filters: Change parse_pred() cpulist ternary into an if block
authorValentin Schneider <vschneid@redhat.com>
Fri, 1 Sep 2023 15:10:38 +0000 (17:10 +0200)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Sat, 2 Sep 2023 01:27:22 +0000 (21:27 -0400)
Review comments noted that an if block would be clearer than a ternary, so
swap it out.

No change in behaviour intended

Link: https://lkml.kernel.org/r/20230901151039.125186-4-vschneid@redhat.com
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Valentin Schneider <vschneid@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_filter.c

index eb331e8..09b4733 100644 (file)
@@ -1782,13 +1782,17 @@ static int parse_pred(const char *str, void *data,
                                FILTER_PRED_FN_CPUMASK;
                } else if (field->filter_type == FILTER_CPU) {
                        if (single) {
-                               pred->op = pred->op == OP_BAND ? OP_EQ : pred->op;
+                               if (pred->op == OP_BAND)
+                                       pred->op = OP_EQ;
+
                                pred->fn_num = FILTER_PRED_FN_CPU;
                        } else {
                                pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK;
                        }
                } else if (single) {
-                       pred->op = pred->op == OP_BAND ? OP_EQ : pred->op;
+                       if (pred->op == OP_BAND)
+                               pred->op = OP_EQ;
+
                        pred->fn_num = select_comparison_fn(pred->op, field->size, false);
                        if (pred->op == OP_NE)
                                pred->not = 1;