Input: synaptics-rmi4 - fix firmware update operations with bootloader v8
authorMatthias Schiffer <matthias.schiffer@ew.tq-group.com>
Wed, 8 Jun 2022 12:48:00 +0000 (14:48 +0200)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 23 Sep 2022 20:00:13 +0000 (13:00 -0700)
Commit a6977d758fed ("Input: synaptics-rmi4 - support bootloader v8 in
f34v7") allowed the F34v7 driver to probe with bootloader v8, but it did
not update various other bootloader version checks in the F34 code.

Fixes: a6977d758fed ("Input: synaptics-rmi4 - support bootloader v8 in f34v7")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Link: https://lore.kernel.org/r/20220608124808.51402-2-matthias.schiffer@ew.tq-group.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_f34.c

index e5dca98..3afc94f 100644 (file)
@@ -370,7 +370,7 @@ static int rmi_firmware_update(struct rmi_driver_data *data,
 
        f34 = dev_get_drvdata(&data->f34_container->dev);
 
-       if (f34->bl_version == 7) {
+       if (f34->bl_version >= 7) {
                if (data->pdt_props & HAS_BSR) {
                        dev_err(dev, "%s: LTS not supported\n", __func__);
                        return -ENODEV;
@@ -382,7 +382,7 @@ static int rmi_firmware_update(struct rmi_driver_data *data,
        }
 
        /* Enter flash mode */
-       if (f34->bl_version == 7)
+       if (f34->bl_version >= 7)
                ret = rmi_f34v7_start_reflash(f34, fw);
        else
                ret = rmi_f34_enable_flash(f34);
@@ -413,7 +413,7 @@ static int rmi_firmware_update(struct rmi_driver_data *data,
        f34 = dev_get_drvdata(&data->f34_container->dev);
 
        /* Perform firmware update */
-       if (f34->bl_version == 7)
+       if (f34->bl_version >= 7)
                ret = rmi_f34v7_do_reflash(f34, fw);
        else
                ret = rmi_f34_update_firmware(f34, fw);