dt-bindings: Add a help message when dtschema tools are missing
authorRob Herring <robh@kernel.org>
Tue, 26 Oct 2021 15:11:17 +0000 (10:11 -0500)
committerRob Herring <robh@kernel.org>
Thu, 28 Oct 2021 12:27:26 +0000 (07:27 -0500)
The dtschema version check works, but is not that clear when dtschema is
either not installed or not in the PATH. Add a separate check and
message if dt-doc-validate is not found.

Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Documentation/devicetree/bindings/Makefile

index 8d6d912c6a6aa89e4156d8cbc0b82d97fcbb20bf..c9abfbe3f0aa27c2e8a68e0161e5b096abedaa80 100644 (file)
@@ -9,6 +9,11 @@ DT_SCHEMA_MIN_VERSION = 2021.2.1
 
 PHONY += check_dtschema_version
 check_dtschema_version:
+       @which $(DT_DOC_CHECKER) >/dev/null || \
+               { echo "Error: '$(DT_DOC_CHECKER)' not found!" >&2; \
+                 echo "Ensure dtschema python package is installed and in your PATH." >&2; \
+                 echo "Current PATH is:" >&2; \
+                 echo "$$PATH" >&2; false; }
        @{ echo $(DT_SCHEMA_MIN_VERSION); \
        $(DT_DOC_CHECKER) --version 2>/dev/null || echo 0; } | sort -Vc >/dev/null || \
        { echo "ERROR: dtschema minimum version is v$(DT_SCHEMA_MIN_VERSION)" >&2; false; }