devlink: use min_t to calculate data_size
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 28 Nov 2022 20:36:39 +0000 (12:36 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 1 Dec 2022 04:54:29 +0000 (20:54 -0800)
The calculation for the data_size in the devlink_nl_read_snapshot_fill
function uses an if statement that is better expressed using the min_t
macro.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/devlink.c

index 0e10a8a..6ef9974 100644 (file)
@@ -6485,10 +6485,8 @@ static int devlink_nl_region_read_snapshot_fill(struct sk_buff *skb,
                u32 data_size;
                u8 *data;
 
-               if (end_offset - curr_offset < DEVLINK_REGION_READ_CHUNK_SIZE)
-                       data_size = end_offset - curr_offset;
-               else
-                       data_size = DEVLINK_REGION_READ_CHUNK_SIZE;
+               data_size = min_t(u32, end_offset - curr_offset,
+                                 DEVLINK_REGION_READ_CHUNK_SIZE);
 
                data = &snapshot->data[curr_offset];
                err = devlink_nl_cmd_region_read_chunk_fill(skb, devlink,