[Prevent] Unhandled isWidgetInstalled return value.
authorJan Olszak <j.olszak@samsung.com>
Tue, 11 Dec 2012 10:44:53 +0000 (11:44 +0100)
committerGerrit Code Review <gerrit2@kim11>
Wed, 12 Dec 2012 13:43:32 +0000 (22:43 +0900)
[Issue] Unchecked condition during setting widgets name.
[Bug] Prevent: 22806
[Cause] N/A
[Solution] Checked condition, throw exception if widget not installed
[Verification] Build commons. Run tests.

Change-Id: I24f7a1960d7fb0dad4b8a024c797b28229c447bc

modules/widget_dao/dao/widget_dao.cpp

index 44389c7..db2e682 100644 (file)
@@ -111,7 +111,10 @@ void WidgetDAO::setPkgName_TEMPORARY_API(const WidgetPkgName& pkgName)
         using namespace DPL::DB::ORM;
         wrt::ScopedTransaction transaction(&WrtDatabase::interface());
 
-        isWidgetInstalled(getHandle());
+        if (!isWidgetInstalled(getHandle())) {
+            ThrowMsg(WidgetDAOReadOnly::Exception::WidgetNotExist,
+                "Cannot find widget. Handle: " << getHandle());
+        }
 
         wrt::WidgetInfo::Row row;
         row.Set_pkgname(pkgName);