remove build warning in core logic

Change-Id: I8ce35b23cf8b61430f172effce9c1051ef021730
Signed-off-by: giyeol.ok <giyeol.ok@samsung.com>

diff --git a/src/battery/lowbat-handler.c b/src/battery/lowbat-handler.c
index 1bee913..e4a1ffc 100644 (file)
--- a/src/battery/lowbat-handler.c
+++ b/src/battery/lowbat-handler.c
@@ -209,7 +209,6 @@ static int lowbat_process(int bat_percent, void *ad)
                        cur_bat_capacity = new_bat_capacity;
        }
 
-
        if (vconf_get_int(VCONFKEY_SYSMAN_BATTERY_STATUS_LOW, &vconf_state) < 0) {
                _E("vconf_get_int() failed");
                return -1;
@@ -365,7 +364,7 @@ static int __check_lowbat_percent(int *pct)
        return 0;
 }
 
-int ss_lowbat_monitor(void *data)
+Eina_Bool ss_lowbat_monitor(void *data)
 {
        struct ss_main_data *ad = (struct ss_main_data *)data;
        int bat_percent, r;
@@ -409,7 +408,7 @@ static int check_battery()
        return ret;
 }
 
-int lowbat_popup(void *data)
+static Eina_Bool lowbat_popup(void *data)
 {
        int ret = -1, state = 0;
        ret = vconf_get_int(VCONFKEY_STARTER_SEQUENCE, &state);
@@ -430,17 +429,15 @@ int lowbat_popup(void *data)
                if (ret < 0) {
                        _E("popup lauch failed");
                        bundle_free(b);
-                       return 1;
+                       return EINA_TRUE;
                }
                lowbat_popup_id = NULL;
                lowbat_popup_option = 0;
                bundle_free(b);
-       } else {
-               _D("boot-animation running yet");
-               return 1;
+               return EINA_TRUE;
        }
-
-       return 0;
+       _D("boot-animation running yet");
+       return EINA_FALSE;
 }
 
 int lowbat_def_predefine_action(int argc, char **argv)

diff --git a/src/bs/bs.c b/src/bs/bs.c
index 7453375..3d04ad4 100644 (file)
--- a/src/bs/bs.c
+++ b/src/bs/bs.c
@@ -293,6 +293,7 @@ static int crash_arg_parser(char *linebuffer, struct crash_arg *arg)
        else
                return 0;
 }
+
 static void launch_crash_worker(const char *filename, int popup_on)
 {
        static int popup_pid = 0;

diff --git a/src/core/core.c b/src/core/core.c
index 7213786..d62c533 100644 (file)
--- a/src/core/core.c
+++ b/src/core/core.c
@@ -69,7 +69,7 @@ static int _ss_core_action_run(void *user_data,
        return 0;
 }
 
-static int core_pipe_cb(void *userdata, Ecore_Fd_Handler * fd_handler)
+static Eina_Bool core_pipe_cb(void *userdata, Ecore_Fd_Handler * fd_handler)
 {
        struct ss_main_data *ad = (struct ss_main_data *)userdata;
        struct _internal_msg p_msg;
@@ -77,7 +77,7 @@ static int core_pipe_cb(void *userdata, Ecore_Fd_Handler * fd_handler)
        int r = -1;
        if (!ecore_main_fd_handler_active_get(fd_handler, ECORE_FD_READ)) {
                _E("ecore_main_fd_handler_active_get error , return");
-               return 1;
+               return EINA_TRUE;
        }
 
        while (retry_count < 5) {
@@ -106,7 +106,7 @@ static int core_pipe_cb(void *userdata, Ecore_Fd_Handler * fd_handler)
                ss_run_queue_del_bypid(p_msg.pid);
                break;
        }
-       return 1;
+       return EINA_TRUE;
 }
 
 int ss_core_action_run()

diff --git a/src/core/device-change-handler.c b/src/core/device-change-handler.c
index b053811..9a86cc5 100644 (file)
--- a/src/core/device-change-handler.c
+++ b/src/core/device-change-handler.c
@@ -127,7 +127,7 @@ static struct extcon_device {
        { EXTCON_EARJACK, "/csa/factory/earjack_count", 0, 0},
 };
 
-static int uevent_control_cb(void *data, Ecore_Fd_Handler *fd_handler);
+static Eina_Bool uevent_control_cb(void *data, Ecore_Fd_Handler *fd_handler);
 extern int battery_power_off_act(void *data);
 extern int battery_charge_err_act(void *data);
 static int check_lowbat_charge_device(int bInserted)
@@ -327,6 +327,7 @@ static void ta_chgdet_cb(struct ss_main_data *ad)
                        snprintf(params, sizeof(params), "%d", CB_NOTI_BATT_CHARGE);
                        ss_launch_if_noexist("/usr/bin/sys_device_noti", params);
                        _D("ta device notification");
+                       device_notify(DEVICE_NOTIFIER_TA, (void *)TRUE);
                }
                __sync_usb_status();
        }
@@ -668,37 +669,41 @@ static int uevent_control_start(void)
        return 0;
 }
 
-static int uevent_control_cb(void *data, Ecore_Fd_Handler *fd_handler)
+static Eina_Bool uevent_control_cb(void *data, Ecore_Fd_Handler *fd_handler)
 {
        struct udev_device *dev = NULL;
        struct udev_list_entry *list_entry = NULL;
-       char *env_name = NULL;
-       char *env_value = NULL;
+       const char *env_name = NULL;
+       const char *env_value = NULL;
+       const char *devpath;
+       const char *devnode;
+       const char *action;
        int ufd = -1;
        int ret = -1;
+       int i, len;
 
        if (!ecore_main_fd_handler_active_get(fd_handler,ECORE_FD_READ))
-               return -1;
+               goto out;
        if ((ufd = ecore_main_fd_handler_fd_get(fd_handler)) == -1)
-               return -1;
+               goto out;
        if ((dev = udev_monitor_receive_device(mon)) == NULL)
-               return -1;
+               goto out;
 
        env_name = udev_device_get_subsystem(dev);
        if (strncmp(env_name, INPUT_SUBSYSTEM, strlen(INPUT_SUBSYSTEM)) == 0) {
                char *devpath = udev_device_get_devpath(dev);
                /* check new input device */
                if (!fnmatch(INPUT_PATH, devpath, 0)) {
-                       char *action = udev_device_get_action(dev);
-                       char *devnode = udev_device_get_devnode(dev);
+                       action = udev_device_get_action(dev);
+                       devnode = udev_device_get_devnode(dev);
                        if (!strcmp(action, ADD))
-                               device_notify(DEVICE_NOTIFIER_INPUT_ADD, devnode);
+                               device_notify(DEVICE_NOTIFIER_INPUT_ADD, (void *)devnode);
                        else if (!strcmp(action, REMOVE))
-                               device_notify(DEVICE_NOTIFIER_INPUT_REMOVE, devnode);
+                               device_notify(DEVICE_NOTIFIER_INPUT_REMOVE, (void *)devnode);
                        udev_device_unref(dev);
                        uevent_control_stop(ufd);
                        uevent_control_start();
-                       return 0;
+                       return EINA_TRUE;
                }
        }
 
@@ -713,7 +718,7 @@ static int uevent_control_cb(void *data, Ecore_Fd_Handler *fd_handler)
 
        if (ret != 0) {
                udev_device_unref(dev);
-               return -1;
+               goto out;
        }
 
        _I("UEVENT DETECTED (%s)", env_value);
@@ -722,8 +727,8 @@ static int uevent_control_cb(void *data, Ecore_Fd_Handler *fd_handler)
        udev_device_unref(dev);
        uevent_control_stop(ufd);
        uevent_control_start();
-
-       return 0;
+out:
+       return EINA_TRUE;
 }
 
 int changed_device_def_predefine_action(int argc, char **argv)
@@ -874,7 +879,8 @@ static void device_change_init(void *data)
        ss_noti_add("device_pci_keyboard_add", (void *)pci_keyboard_add_cb, data);
        ss_noti_add("device_pci_keyboard_remove", (void *)pci_keyboard_remove_cb, data);
 
-       if (vconf_notify_key_changed(VCONFKEY_SYSMAN_USB_HOST_STATUS, usb_host_chgdet_cb, NULL) < 0) {
+       if (vconf_notify_key_changed(VCONFKEY_SYSMAN_USB_HOST_STATUS,
+               (void *)usb_host_chgdet_cb, NULL) < 0) {
                _E("vconf key notify failed(VCONFKEY_SYSMAN_USB_HOST_STATUS)");
        }
 

diff --git a/src/core/device-handler.h b/src/core/device-handler.h
index f08481c..62e7c99 100644 (file)
--- a/src/core/device-handler.h
+++ b/src/core/device-handler.h
@@ -20,6 +20,8 @@
 #ifndef __DEVICE_HANDLER_H__
 #define __DEVICE_HANDLER_H__
 
+#include "data.h"
+
 enum extcon_type {
        EXTCON_TA = 0,
        EXTCON_EARJACK,
@@ -37,7 +39,7 @@ int _ss_usb_storage_init(void);
 /* Battery functions */
 int ss_lowbat_is_charge_in_now();
 int ss_lowbat_set_charge_on(int onoff);
-int ss_lowbat_monitor(void *data);
+Eina_Bool ss_lowbat_monitor(void *data);
 
 int extcon_set_count(int index);
 

diff --git a/src/core/device-notifier.c b/src/core/device-notifier.c
index ba59a18..b6c8a49 100644 (file)
--- a/src/core/device-notifier.c
+++ b/src/core/device-notifier.c
@@ -102,7 +102,7 @@ void device_notify(enum device_notifier_type status, void *data)
        }
 }
 
-static void device_notifier_exit(void)
+static void device_notifier_exit(void *data)
 {
        Eina_List *n, *next;
        struct device_notifier *notifier;

diff --git a/src/core/device-notifier.h b/src/core/device-notifier.h
index 7737ff9..5b290e3 100644 (file)
--- a/src/core/device-notifier.h
+++ b/src/core/device-notifier.h
@@ -22,6 +22,7 @@
 
 enum device_notifier_type {
        DEVICE_NOTIFIER_LCD,
+       DEVICE_NOTIFIER_TA,
        DEVICE_NOTIFIER_INPUT_ADD,
        DEVICE_NOTIFIER_INPUT_REMOVE,
        DEVICE_NOTIFIER_PROCESS_TERMINATED,

diff --git a/src/core/devices.c b/src/core/devices.c
index 47f11dc..e6711ee 100644 (file)
--- a/src/core/devices.c
+++ b/src/core/devices.c
@@ -56,7 +56,7 @@ void devices_init(void *data)
 {
        int i;
        int size;
-       struct device_ops *dev;
+       const struct device_ops *dev;
 
        size = ARRAY_SIZE(devices);
        for(i = 0; i < size; ++i) {
@@ -70,7 +70,7 @@ void devices_exit(void *data)
 {
        int i;
        int size;
-       struct device_ops *dev;
+       const struct device_ops *dev;
 
        size = ARRAY_SIZE(devices);
        for(i = 0; i < size; ++i) {

diff --git a/src/core/devices.h b/src/core/devices.h
index 72f428c..32cc7be 100644 (file)
--- a/src/core/devices.h
+++ b/src/core/devices.h
@@ -40,7 +40,7 @@ enum device_ops_status {
 void devices_init(void *data);
 void devices_exit(void *data);
 
-static inline int device_start(struct device_ops *dev)
+static inline int device_start(const struct device_ops *dev)
 {
        if (dev && dev->start)
                return dev->start();
@@ -48,7 +48,7 @@ static inline int device_start(struct device_ops *dev)
        return -EINVAL;
 }
 
-static inline int device_stop(struct device_ops *dev)
+static inline int device_stop(const struct device_ops *dev)
 {
        if (dev && dev->stop)
                return dev->stop();
@@ -56,7 +56,7 @@ static inline int device_stop(struct device_ops *dev)
        return -EINVAL;
 }
 
-static inline int device_get_status(struct device_ops *dev)
+static inline int device_get_status(const struct device_ops *dev)
 {
        if (dev && dev->status)
                return dev->status();

diff --git a/src/core/edbus-handler.c b/src/core/edbus-handler.c
index aa8056c..a80a89e 100644 (file)
--- a/src/core/edbus-handler.c
+++ b/src/core/edbus-handler.c
@@ -248,7 +248,8 @@ static DBusHandlerResult message_filter(DBusConnection *connection,
 {
        char match[256];
        int ret;
-       const char *iface, *member, *watch, *arg = NULL;
+       const char *iface, *member, *arg = NULL;
+       char *watch;
        Eina_List *l;
 
        if (dbus_message_get_type(message) != DBUS_MESSAGE_TYPE_SIGNAL)
@@ -276,7 +277,7 @@ static DBusHandlerResult message_filter(DBusConnection *connection,
                if (strcmp(arg, watch)) continue;
 
                /* notify 'process terminated' to device notifiers */
-               device_notify(DEVICE_NOTIFIER_PROCESS_TERMINATED, watch);
+               device_notify(DEVICE_NOTIFIER_PROCESS_TERMINATED, (void *)watch);
 
                /* remove registered sender */
                snprintf(match, sizeof(match), NAME_OWNER_MATCH, watch);
@@ -297,7 +298,8 @@ static DBusHandlerResult message_filter(DBusConnection *connection,
 int register_edbus_watch(DBusMessage *msg)
 {
        char match[256];
-       const char *sender, *watch;
+       const char *sender;
+       char *watch;
        Eina_List *l;
        int ret;
 

diff --git a/src/core/launch.c b/src/core/launch.c
index bf50231..b6c85c3 100644 (file)
--- a/src/core/launch.c
+++ b/src/core/launch.c
@@ -39,7 +39,8 @@ int ss_set_current_lang(void)
 {
        char *lang;
        int ret;
-       lang = vconf_get_str(VCONFKEY_LANGSET);
+
+       lang = (char *)vconf_get_str(VCONFKEY_LANGSET);
        if (lang == NULL)
                return -1;
        ret = setenv("LANG", lang, 1);

diff --git a/src/core/list.h b/src/core/list.h
index 6251e0a..6d8f8c8 100644 (file)
--- a/src/core/list.h
+++ b/src/core/list.h
@@ -30,7 +30,7 @@
 #define EINA_LIST_REMOVE_LIST(a, b) \
        a = eina_list_remove_list(a, b)
 
-#define EINA_LIST_FREE(a) \
+#define EINA_LIST_FREE_LIST(a) \
        a = eina_list_free(a)
 
 #endif

diff --git a/src/core/sysnoti.c b/src/core/sysnoti.c
index 202d6bc..18299a0 100644 (file)
--- a/src/core/sysnoti.c
+++ b/src/core/sysnoti.c
@@ -197,7 +197,7 @@ static bool check_sync_request(struct sysnoti *msg)
        return true;
 }
 
-static int sysnoti_cb(void *data, Ecore_Fd_Handler * fd_handler)
+static Eina_Bool sysnoti_cb(void *data, Ecore_Fd_Handler * fd_handler)
 {
        int fd;
        struct sysnoti *msg;
@@ -209,14 +209,14 @@ static int sysnoti_cb(void *data, Ecore_Fd_Handler * fd_handler)
 
        if (!ecore_main_fd_handler_active_get(fd_handler, ECORE_FD_READ)) {
                _E("ecore_main_fd_handler_active_get error , return");
-               return 1;
+               goto out;
        }
 
        fd = ecore_main_fd_handler_fd_get(fd_handler);
        msg = malloc(sizeof(struct sysnoti));
        if (msg == NULL) {
                _E("Not enough memory");
-               return 1;
+               goto out;
        }
 
        client_len = sizeof(client_address);
@@ -225,7 +225,7 @@ static int sysnoti_cb(void *data, Ecore_Fd_Handler * fd_handler)
        if (client_sockfd == -1) {
                _E("socket accept error");
                free(msg);
-               return -1;
+               goto out;
        }
        if (read_message(client_sockfd, msg) < 0) {
                _E("recv error msg");
@@ -235,7 +235,7 @@ static int sysnoti_cb(void *data, Ecore_Fd_Handler * fd_handler)
                close(client_sockfd);
                __sysnoti_stop(fd);
                __sysnoti_start();
-               return -1;
+               goto out;
        }
 
        sync = check_sync_request(msg);
@@ -247,7 +247,7 @@ static int sysnoti_cb(void *data, Ecore_Fd_Handler * fd_handler)
                if (sync)
                        write(client_sockfd, &ret, sizeof(int));
                close(client_sockfd);
-               return -1;
+               goto out;
        }
 
        switch (msg->cmd) {
@@ -263,8 +263,8 @@ static int sysnoti_cb(void *data, Ecore_Fd_Handler * fd_handler)
        close(client_sockfd);
 
        free_message(msg);
-
-       return 1;
+out:
+       return EINA_TRUE;
 }
 
 static int ss_sysnoti_server_init(void)

diff --git a/src/mmc/mmc-handler.c b/src/mmc/mmc-handler.c
index e458cc3..4d3aef3 100644 (file)
--- a/src/mmc/mmc-handler.c
+++ b/src/mmc/mmc-handler.c
@@ -129,7 +129,7 @@ static int exec_process(const char **argv)
        if (!pid) {
                for (i = 0; i < _NSIG; ++i)
                        signal(i, SIG_DFL);
-               r = execv(argv[0], argv);
+               r = execv(argv[0], (char **)argv);
                if (r == -1) {
                        _E("execv() error");
                        exit(EXIT_FAILURE);
@@ -325,7 +325,7 @@ static int create_partition(const char *dev_path)
 static int kill_app_accessing_mmc(void)
 {
        int pid;
-       char *argv[4] = {"/sbin/fuser", "-mk", MMC_MOUNT_POINT, NULL};
+       const char *argv[4] = {"/sbin/fuser", "-mk", MMC_MOUNT_POINT, NULL};
        char buf[256];
        int retry = 10;
 
@@ -798,17 +798,19 @@ static void mmc_init(void *data)
        mmc_mount();
 }
 
-static void mmc_start(void)
+static int mmc_start(void)
 {
        mmc_disabled = false;
        _D("start");
+       return 0;
 }
 
-static void mmc_stop(void)
+static int mmc_stop(void)
 {
        mmc_disabled = true;
        vconf_set_int(VCONFKEY_SYSMAN_MMC_STATUS, VCONFKEY_SYSMAN_MMC_REMOVED);
        _D("stop");
+       return 0;
 }
 
 const struct device_ops mmc_device_ops = {

diff --git a/src/proc/lowmem-handler.c b/src/proc/lowmem-handler.c
index bd09b55..4db9a12 100644 (file)
--- a/src/proc/lowmem-handler.c
+++ b/src/proc/lowmem-handler.c
@@ -64,7 +64,7 @@
 struct lowmem_process_entry {
        unsigned cur_mem_state;
        unsigned new_mem_state;
-       int (*action) (void *);
+       Eina_Bool (*action) (void *);
 };
 
 static int lowmem_fd = -1;
@@ -73,9 +73,9 @@ static int cur_mem_state = MEMNOTIFY_NORMAL;
 Ecore_Timer *oom_timer;
 #define OOM_TIMER_INTERVAL     5
 
-static int memory_low_act(void *ad);
-static int memory_oom_act(void *ad);
-static int memory_normal_act(void *ad);
+static Eina_Bool memory_low_act(void *ad);
+static Eina_Bool memory_oom_act(void *ad);
+static Eina_Bool memory_normal_act(void *ad);
 
 static struct lowmem_process_entry lpe[] = {
        {MEMNOTIFY_NORMAL, MEMNOTIFY_LOW, memory_low_act},
@@ -215,7 +215,7 @@ static void make_LMM_log(char *file, pid_t pid, char *victim_name)
 
 
 
-static int memory_low_act(void *data)
+static Eina_Bool memory_low_act(void *data)
 {
        char lowmem_noti_name[NAME_MAX];
 
@@ -227,10 +227,10 @@ static int memory_low_act(void *data)
        vconf_set_int(VCONFKEY_SYSMAN_LOW_MEMORY,
                      VCONFKEY_SYSMAN_LOW_MEMORY_SOFT_WARNING);
 
-       return 0;
+       return EINA_TRUE;
 }
 
-static int memory_oom_act(void *data)
+static Eina_Bool memory_oom_act(void *data)
 {
        unsigned int cur_time;
        char lowmem_noti_name[NAME_MAX];
@@ -252,15 +252,15 @@ static int memory_oom_act(void *data)
        vconf_set_int(VCONFKEY_SYSMAN_LOW_MEMORY,
                      VCONFKEY_SYSMAN_LOW_MEMORY_HARD_WARNING);
 
-       return 1;
+       return EINA_TRUE;
 }
 
-static int memory_normal_act(void *data)
+static Eina_Bool memory_normal_act(void *data)
 {
        _I("[LOW MEM STATE] memory normal state");
        vconf_set_int(VCONFKEY_SYSMAN_LOW_MEMORY,
                      VCONFKEY_SYSMAN_LOW_MEMORY_NORMAL);
-       return 0;
+       return EINA_TRUE;
 }
 
 static int lowmem_process(unsigned int mem_state, void *ad)
@@ -292,7 +292,7 @@ static unsigned int lowmem_read(int fd)
        }
        return mem_state;
 }
-static int lowmem_cb(void *data, Ecore_Fd_Handler * fd_handler)
+static Eina_Bool lowmem_cb(void *data, Ecore_Fd_Handler * fd_handler)
 {
        int fd;
        struct ss_main_data *ad = (struct ss_main_data *)data;
@@ -300,20 +300,20 @@ static int lowmem_cb(void *data, Ecore_Fd_Handler * fd_handler)
 
        if (!ecore_main_fd_handler_active_get(fd_handler, ECORE_FD_READ)) {
                _E("ecore_main_fd_handler_active_get error, return");
-               return -1;
+               goto out;
        }
 
        fd = ecore_main_fd_handler_fd_get(fd_handler);
        if (fd < 0) {
                _E("ecore_main_fd_handler_fd_get error, return");
-               return -1;
+               goto out;
        }
        mem_state = lowmem_read(fd);
        print_lowmem_state(mem_state);
        lowmem_process(mem_state, ad);
        cur_mem_state = mem_state;
-
-       return 1;
+out:
+       return EINA_TRUE;
 }
 
 static int set_threshold()

diff --git a/src/proc/pmon-handler.c b/src/proc/pmon-handler.c
index 33b6d7f..e3324d9 100644 (file)
--- a/src/proc/pmon-handler.c
+++ b/src/proc/pmon-handler.c
@@ -187,40 +187,41 @@ static unsigned int pmon_read(int fd)
 }
 */
 
-static int pmon_cb(void *data, Ecore_Fd_Handler * fd_handler)
+static Eina_Bool pmon_cb(void *data, Ecore_Fd_Handler * fd_handler)
 {
        int fd;
        struct ss_main_data *ad = (struct ss_main_data *)data;
        int dead_pid;
        if (!ecore_main_fd_handler_active_get(fd_handler, ECORE_FD_READ)) {
                _E("ecore_main_fd_handler_active_get error , return");
-               return -1;
+               goto out;
        }
 
        fd = ecore_main_fd_handler_fd_get(fd_handler);
 
        if (fd < 0) {
                _E("ecore_main_fd_handler_fd_get error , return");
-               return -1;
+               goto out;
        }
        if (read(fd, &dead_pid, sizeof(dead_pid)) < 0) {
                __pmon_stop(fd);
                _E("Reading DEAD_PID failed, restart ecore fd");
                __pmon_start(ad);
-               return -1;
+               goto out;
        }
 
        print_pmon_state(dead_pid);
        pmon_process(dead_pid, ad);
-
-       return 1;
+out:
+       return EINA_TRUE;
 }
 
 static int __pmon_start(struct ss_main_data *ad)
 {
        int pmon_fd = -1;
        char pmon_dev_node[PATH_MAX];
-       if (device_get_property(DEVICE_TYPE_PROCESS, PROP_PROCESS_NODE, pmon_dev_node) < 0) {
+       if (device_get_property(DEVICE_TYPE_PROCESS, PROP_PROCESS_NODE,
+               (int *)pmon_dev_node) < 0) {
                _E("ss_pmon_init get dev node path failed");
                return -1;
        }

diff --git a/src/time/time-handler.c b/src/time/time-handler.c
index 9b46542..76b5174 100644 (file)
--- a/src/time/time-handler.c
+++ b/src/time/time-handler.c
@@ -65,7 +65,7 @@ static const char default_localtime[] = "/opt/etc/localtime";
 static const time_t default_time = 2147483645; // max(32bit) -3sec
 static Ecore_Fd_Handler *tfdh = NULL; // tfd change noti
 
-static int tfd_cb(void *data, Ecore_Fd_Handler * fd_handler);
+static Eina_Bool tfd_cb(void *data, Ecore_Fd_Handler * fd_handler);
 static int timerfd_check_stop(int fd);
 static int timerfd_check_start(void);
 
@@ -236,7 +236,7 @@ static int timerfd_check_stop(int tfd)
        return 0;
 }
 
-static int tfd_cb(void *data, Ecore_Fd_Handler * fd_handler)
+static Eina_Bool tfd_cb(void *data, Ecore_Fd_Handler * fd_handler)
 {
        int tfd = -1;
        u_int64_t ticks;
@@ -244,12 +244,12 @@ static int tfd_cb(void *data, Ecore_Fd_Handler * fd_handler)
 
        if (!ecore_main_fd_handler_active_get(fd_handler,ECORE_FD_READ)) {
                _E("error ecore_main_fd_handler_get()");
-               return -1;
+               goto out;
        }
 
        if((tfd = ecore_main_fd_handler_fd_get(fd_handler)) == -1) {
                _E("error ecore_main_fd_handler_fd_get()");
-               return -1;
+               goto out;
        }
 
        ret = read(tfd,&ticks,sizeof(ticks));
@@ -261,7 +261,8 @@ static int tfd_cb(void *data, Ecore_Fd_Handler * fd_handler)
        } else {
                _D("unexpected read (err:%d)",errno);
        }
-       return 0;
+out:
+       return EINA_TRUE;
 }
 
 static void time_init(void *data)