PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 12:24:53 +0000 (20:24 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thu, 3 Jun 2021 16:45:52 +0000 (17:45 +0100)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Link: https://lore.kernel.org/r/20210511122453.6052-1-thunder.leizhen@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Krzysztof WilczyƄski <kw@linux.com>
drivers/pci/controller/pcie-mediatek.c

index 62a042e75d9a2f4615a7b0319309f0fb92af6c42..25bee693834f95e282526992c430e78bce8ae79e 100644 (file)
@@ -991,10 +991,8 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie)
        regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "subsys");
        if (regs) {
                pcie->base = devm_ioremap_resource(dev, regs);
-               if (IS_ERR(pcie->base)) {
-                       dev_err(dev, "failed to map shared register\n");
+               if (IS_ERR(pcie->base))
                        return PTR_ERR(pcie->base);
-               }
        }
 
        pcie->free_ck = devm_clk_get(dev, "free_ck");