xfrm: mip6: add extack to mip6_destopt_init_state, mip6_rthdr_init_state
authorSabrina Dubroca <sd@queasysnail.net>
Tue, 27 Sep 2022 15:45:34 +0000 (17:45 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Thu, 29 Sep 2022 05:18:01 +0000 (07:18 +0200)
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/ipv6/mip6.c

index 3d87ae88ebfdfc61a364aaaa9f7fe23a25934ea6..83d2a8be263fb7bdd0cbe820168b1aac9a4336b2 100644 (file)
@@ -250,12 +250,11 @@ static int mip6_destopt_reject(struct xfrm_state *x, struct sk_buff *skb,
 static int mip6_destopt_init_state(struct xfrm_state *x, struct netlink_ext_ack *extack)
 {
        if (x->id.spi) {
-               pr_info("%s: spi is not 0: %u\n", __func__, x->id.spi);
+               NL_SET_ERR_MSG(extack, "SPI must be 0");
                return -EINVAL;
        }
        if (x->props.mode != XFRM_MODE_ROUTEOPTIMIZATION) {
-               pr_info("%s: state's mode is not %u: %u\n",
-                       __func__, XFRM_MODE_ROUTEOPTIMIZATION, x->props.mode);
+               NL_SET_ERR_MSG(extack, "XFRM mode must be XFRM_MODE_ROUTEOPTIMIZATION");
                return -EINVAL;
        }
 
@@ -336,12 +335,11 @@ static int mip6_rthdr_output(struct xfrm_state *x, struct sk_buff *skb)
 static int mip6_rthdr_init_state(struct xfrm_state *x, struct netlink_ext_ack *extack)
 {
        if (x->id.spi) {
-               pr_info("%s: spi is not 0: %u\n", __func__, x->id.spi);
+               NL_SET_ERR_MSG(extack, "SPI must be 0");
                return -EINVAL;
        }
        if (x->props.mode != XFRM_MODE_ROUTEOPTIMIZATION) {
-               pr_info("%s: state's mode is not %u: %u\n",
-                       __func__, XFRM_MODE_ROUTEOPTIMIZATION, x->props.mode);
+               NL_SET_ERR_MSG(extack, "XFRM mode must be XFRM_MODE_ROUTEOPTIMIZATION");
                return -EINVAL;
        }