802: Convert compare_ether_addr to ether_addr_equal
authorJoe Perches <joe@perches.com>
Tue, 8 May 2012 18:56:46 +0000 (18:56 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 May 2012 00:49:17 +0000 (20:49 -0400)
Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.

Done via cocci script:

$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
- !compare_ether_addr(a, b)
+ ether_addr_equal(a, b)

@@
expression a,b;
@@
- compare_ether_addr(a, b)
+ !ether_addr_equal(a, b)

@@
expression a,b;
@@
- !ether_addr_equal(a, b) == 0
+ ether_addr_equal(a, b)

@@
expression a,b;
@@
- !ether_addr_equal(a, b) != 0
+ !ether_addr_equal(a, b)

@@
expression a,b;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)

@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)

@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/802/stp.c

index 15540b7..2c40ba0 100644 (file)
@@ -46,7 +46,7 @@ static int stp_pdu_rcv(struct sk_buff *skb, struct net_device *dev,
                proto = rcu_dereference(garp_protos[eh->h_dest[5] -
                                                    GARP_ADDR_MIN]);
                if (proto &&
-                   compare_ether_addr(eh->h_dest, proto->group_address))
+                   !ether_addr_equal(eh->h_dest, proto->group_address))
                        goto err;
        } else
                proto = rcu_dereference(stp_proto);